Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Optionally add task to subset name #1072

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 2, 2021

Changes

  • added ability to change template of subset name for specific creators by settings
  • templates are resolved by profiled filtering similar to ExtractReview profiles
    • available filtering keys are families, hosts and task names
  • result is template with formattable keys family, task and user_input
    • Example template "{family}{user_input}"

Code changes

avalon-core

  • subset template for creator api is defined by Creator class with method get_subset_name
  • this approach is used in Creator tool

pype

  • in pype is defined PypeCreatorMixin which should be used as main inherit class (mixin overrides get_subset_name)
    • this is because we have to propagate only this method to all creator plugins in pype but they may already inherit from avalon's host creator
    • added Creator class for each pype host if is using avalon host Creator
  • modified standalone publisher to be able use this feature and modified to care about tasks
  • added profile filtering function to pype.lib
  • filter for creators are in project settings under Creator tool
    • has defaults that should work the same way as before

pype-config

  • added defaults

Test

  • check creator tool in blender
  • check creator tool in harmony
  • check creator tool in maya
  • check creator tool in nuke
  • check creator tool in photoshop
  • check creator tool in aftereffects
  • check creator tool in houdini
  • check creator tool in tvpaint
🏴 this depends on
avalon-core ynput/avalon-core#289
pype-config ynput/pype-config#101
🏴 Pype 3.x PR
pype #1068
avalon-core ynput/avalon-core#288

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 2, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team March 2, 2021 12:27
@mkolar mkolar added this to the 2.15.4 milestone Mar 3, 2021
@mkolar
Copy link
Member

mkolar commented Mar 3, 2021

harmony and tv paint will be better tested on-site and fixed if anything doesn't work in a followup PR

@mkolar mkolar merged commit ee41f8f into 2.x/develop Mar 3, 2021
@mkolar mkolar deleted the feature/2_0_656-optionally-add-task-to-subset-name branch March 12, 2021 16:04
@mkolar mkolar modified the milestones: 2.15.4, 2.16.0 Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants